Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove email and messages app from monorepo #1503

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

poulch
Copy link
Member

@poulch poulch commented Aug 2, 2024

Scope of the PR

Related issues

Checklist

Copy link

changeset-bot bot commented Aug 2, 2024

⚠️ No Changeset found

Latest commit: 1484f2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-avatax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 10:17am
saleor-app-cms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 10:17am
saleor-app-data-importer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 10:17am
saleor-app-emails-and-messages ❌ Failed (Inspect) 💬 Add feedback Aug 21, 2024 10:17am
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 10:17am
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 10:17am
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 10:17am
saleor-app-smtp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 10:17am

Copy link
Member

@lkostrowski lkostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets first officially create repo with example, add it to docs etc, then we need to check who is using this app. Then, we can remove code and proceed to shut down deployment

@poulch
Copy link
Member Author

poulch commented Aug 8, 2024

Lets first officially create repo with example, add it to docs etc, then we need to check who is using this app. Then, we can remove code and proceed to shut down deployment

Repo is mentioned in README, here is link https://github.com/saleor/example-app-sendgrid

@poulch poulch merged commit 4867232 into main Aug 21, 2024
17 checks passed
@poulch poulch deleted the merx-697-remove-email-and-messages-app branch August 21, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Attach this label to PRs which does not need changes description for the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants