Inputs implementation #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
andrzejewsky
requested review from
krzysztofzuraw
and removed request for
krzysztofzuraw
poulch
approved these changes
Feb 25, 2023
src/components/Input/Input.tsx
Outdated
| "color" | "width" | "height" | "size" | ||
| > & { | ||
| children?: ReactNode; | ||
| disabled?: boolean; |
There was a problem hiding this comment.
suggestion: disabled is already part of InputHTMLAttributes interface
Suggested change
| disabled?: boolean; |
src/components/Input/Input.tsx
Outdated
| const [active, setActive] = useState(false); | ||
| const typed = Boolean(inputValue || active); | ||
|
|
||
| const handleChange = (evt: React.ChangeEvent<HTMLInputElement>) => { |
There was a problem hiding this comment.
suggestion: I'd rather use e | event for event name
krzysztofzuraw
approved these changes
Feb 27, 2023
krzysztofzuraw
approved these changes
Feb 27, 2023
poulch
approved these changes
Feb 27, 2023
Droniu
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #232 (partially closes)