Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: portalize popover & adjust default styling #394

Merged
merged 3 commits into from
Apr 24, 2023
Merged

fix: portalize popover & adjust default styling #394

merged 3 commits into from
Apr 24, 2023

Conversation

Droniu
Copy link
Member

@Droniu Droniu commented Apr 24, 2023 •
edited
Loading

I want to merge this change because it:

  • portalizes Popover.Content
  • adds css adjsutments: padding, default background color and box-shadow property

This PR closes #393.

Screenshots

Before After
image image

Pull Request Checklist

  • New components are exported from ./src/components/index.ts.
  • Storybook story is created and documentation properly generated.

@vercel
Copy link

vercel bot commented Apr 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
macaw-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 8:42am
macaw-ui-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 8:42am

@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 24, 2023 08:41 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 24, 2023 08:42 Inactive
@Droniu Droniu changed the title Portalize popover fix: Portalize popover & adjust default styling Apr 24, 2023
krzysztofzuraw
krzysztofzuraw approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@krzysztofzuraw krzysztofzuraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix commitlint you need to have Portalize in lowercase 😀

@Droniu Droniu changed the title fix: Portalize popover & adjust default styling fix: portalize popover & adjust default styling Apr 24, 2023
@Droniu Droniu merged commit 15ec12e into canary Apr 24, 2023
@Droniu Droniu deleted the 393-portalize-popover branch April 24, 2023 14:37
@Droniu Droniu mentioned this pull request Apr 27, 2023
Merged
60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzysztofzuraw krzysztofzuraw krzysztofzuraw approved these changes

@poulch poulch poulch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popover is not portalized and misses box shadow
3 participants
@Droniu @krzysztofzuraw @poulch