Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disappearing products description #259

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it fixes bug causing description field to be cleared after selecting anything from dropdown input in product create view.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #259 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   73.97%   73.97%           
=======================================
  Files         604      604           
  Lines        6481     6481           
  Branches     1063     1063           
=======================================
  Hits         4794     4794           
  Misses       1501     1501           
  Partials      186      186
Impacted Files Coverage Δ
...components/ProductCreatePage/ProductCreatePage.tsx 92.3% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb8af89...8775f87. Read the comment docs.

@maarcingebala maarcingebala merged commit 89cdb94 into master Nov 19, 2019
@maarcingebala maarcingebala deleted the fix/product-description branch November 19, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants