Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add navigator #267

Merged
merged 22 commits into from
Nov 26, 2019
Merged

Add navigator #267

merged 22 commits into from
Nov 26, 2019

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Nov 22, 2019

I want to merge this because it adds the navigator. It allows to quickly move around dashboard as a power user. Also features catalog and customer search.

Screenshots

Screenshot 2019-11-25 at 17 56 00

Screenshot 2019-11-25 at 17 56 17

Screenshot 2019-11-25 at 17 56 33

Screenshot 2019-11-25 at 17 56 52

Screenshot 2019-11-25 at 17 57 01

Screenshot 2019-11-25 at 17 57 26

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #267 into master will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
- Coverage   74.02%   74.01%   -0.01%     
==========================================
  Files         605      605              
  Lines        6490     6492       +2     
  Branches     1063     1065       +2     
==========================================
+ Hits         4804     4805       +1     
  Misses       1501     1501              
- Partials      185      186       +1
Impacted Files Coverage Δ
src/orders/fixtures.ts 100% <ø> (ø) ⬆️
src/theme.ts 100% <ø> (ø) ⬆️
...mponents/CustomerCreatePage/CustomerCreatePage.tsx 63.15% <ø> (ø) ⬆️
src/components/messages/index.ts 100% <ø> (ø) ⬆️
...s/components/CustomerListPage/CustomerListPage.tsx 100% <ø> (ø) ⬆️
...s/components/OrderDetailsPage/OrderDetailsPage.tsx 92% <ø> (ø) ⬆️
src/config.ts 100% <100%> (ø) ⬆️
src/components/messages/MessageManager.tsx 40% <66.66%> (-2.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63621c6...88819f0. Read the comment docs.

@dominik-zeglen dominik-zeglen marked this pull request as ready for review November 25, 2019 16:33
@mirekm
Copy link
Member

mirekm commented Nov 26, 2019

Super cool feature. One issue I found testing is that searching on Clients doesn't seem to be working correctly:
image

Same on Categories and Collections:
image

@mateuszkula
Copy link

Comment on first impression.

Maybe it would be better if position of input was fixed. When writing down something the input is changing its position many times.

Below is presentation what I mean:
Kapture 2019-11-26 at 11 08 17

@maarcingebala
Copy link
Member

@dominik-zeglen When typing an "operator" e.g. # I need to put additional space after it to start searching. It would be more natural to just type #51 to go to order of that ID.

Second thought- it would be nice to somehow present the user available operators as they are not obvious. E.g. in VSCode you can type ? to see the list of available operators. But this could be added later as well.

@maarcingebala
Copy link
Member

@mirekm you need to use @ operator:
image

@dominik-zeglen
Copy link
Contributor Author

I've added help, which should improve discoverability of modes. Pic rel
Screenshot 2019-11-26 at 15 17 51

@mateuszkula thanks for feedback, I've pinned navigator so it won't change its place when typing.

@maarcingebala maarcingebala merged commit 76becb2 into master Nov 26, 2019
@maarcingebala maarcingebala deleted the add/navigator branch November 26, 2019 15:04
@maarcingebala maarcingebala mentioned this pull request Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants