Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mutation state to mutation objects #297

Merged
merged 5 commits into from
Dec 16, 2019

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it resolves #30

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@netlify
Copy link

netlify bot commented Dec 6, 2019

Deploy preview for saleor-dashboard-stage processing.

Building with commit f9e0ffa

https://app.netlify.com/sites/saleor-dashboard-stage/deploys/5dea8df6a61f960008087e2a

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #297 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
- Coverage   74.36%   74.35%   -0.02%     
==========================================
  Files         607      607              
  Lines        6651     6652       +1     
  Branches     1073     1074       +1     
==========================================
  Hits         4946     4946              
- Misses       1518     1519       +1     
  Partials      187      187
Impacted Files Coverage Δ
src/mutations.tsx 8.33% <0%> (ø) ⬆️
src/plugins/views/PluginsDetails.tsx 17.07% <0%> (+0.79%) ⬆️
src/misc.ts 52.74% <0%> (-1.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0d3e1...f9e0ffa. Read the comment docs.

@dominik-zeglen dominik-zeglen changed the title Move mutation state to mutation Move mutation state to mutation objects Dec 9, 2019
Copy link
Member

@tomaszszymanski129 tomaszszymanski129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to split such enormous work to smaller PRs in future, so it would be possible to actually review the thing 😅

@dominik-zeglen
Copy link
Contributor Author

@tomaszszymanski129 this is mostly copypaste 🤷‍♂️

@maarcingebala maarcingebala merged commit 97abf33 into master Dec 16, 2019
@maarcingebala maarcingebala deleted the ref/move-mutation-state-to-mutation branch December 16, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor getMutationState function to accept MutationResult object
3 participants