Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve order filters #396

Merged
merged 6 commits into from
Feb 12, 2020
Merged

Improve order filters #396

merged 6 commits into from
Feb 12, 2020

Conversation

dominik-zeglen
Copy link
Contributor

I want to merge this change because it adds filtering by customer and replaces label "placed" with "created".

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #396 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
+ Coverage   72.45%   72.45%   +<.01%     
==========================================
  Files         639      639              
  Lines        7118     7120       +2     
  Branches     1183     1184       +1     
==========================================
+ Hits         5157     5159       +2     
  Misses       1720     1720              
  Partials      241      241
Impacted Files Coverage Δ
...rc/components/ColumnPicker/ColumnPickerContent.tsx 11.11% <ø> (ø) ⬆️
src/components/ColumnPicker/ColumnPicker.tsx 60% <0%> (ø) ⬆️
...c/storybook/stories/products/ProductUpdatePage.tsx 57.14% <100%> (+2.14%) ⬆️
src/components/VisibilityCard/VisibilityCard.tsx 68.18% <100%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e10b456...24cfd20. Read the comment docs.

@maarcingebala maarcingebala merged commit 287f209 into master Feb 12, 2020
@maarcingebala maarcingebala deleted the add/order-filter-fields branch February 12, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants