Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation Failed! ERROR: Service 'react-storefront' failed to build : Build failed #154

Closed
2 tasks
SohelKabir opened this issue Jun 14, 2022 · 7 comments
Closed
2 tasks
Assignees
Labels
bug Something isn't working

Comments

@SohelKabir
Copy link

SohelKabir commented Jun 14, 2022

What I'm trying to achieve

Steps to reproduce the problem

  1. Follow these steps for install https://docs.saleor.io/docs/3.x/developer/installation with docker
  2. run docker-compose build

What I expected to happen

executor failed running [/bin/sh -c pnpm install]: exit code: 1
ERROR: Service 'react-storefront' failed to build : Build failed

Screenshots and logs

System information

Saleor version:

  • dev (current main)

Operating system:

  • Windows
@SohelKabir SohelKabir added the bug Something isn't working label Jun 14, 2022
@SohelKabir
Copy link
Author

SohelKabir commented Jun 15, 2022

ok i solved the issue, it was problem with pnpm in react-storefront dockerfile.dev file.

Just use yarn instead of pnpm it will work.

my updated dockerfile.dev file react -storefront

FROM node:16
WORKDIR /app

# Setup pnpm package manager
RUN npm install -g yarn pnpm --force


# Setup proxy to API used in saleor-platform
RUN apt-get update && apt-get install -y nginx
COPY ./nginx/dev.conf /etc/nginx/conf.d/default.conf

COPY package.json ./
# COPY pnpm-lock.yaml ./
RUN yarn 
COPY . .
ARG API_URI
ENV API_URI ${API_URI:-http://localhost:8000/graphql/}

EXPOSE 3000
CMD yarn dev -- --hostname 0.0.0.0

@timuric timuric transferred this issue from saleor/saleor Jun 20, 2022
@Crepu
Copy link

Crepu commented Jul 2, 2022

Hi everyone

I was getting the same problem and the @SohelKabir solution worked out with an exception.

I'm working on a Linux (Ubuntu 20) machine and when I tried to install yarn globally, docker give me EEXIST code error. It seems I've already got yarn installed previously, so the build failed.

By removing the global flag work like a charm.

@Ian2012
Copy link

Ian2012 commented Jul 11, 2022

Hi everyone, the right solution is this one: saleor/saleor#9764

I spent three days testing every solution and this is the right

@RashiqAzhan
Copy link

The issue is still here. Is the solution here or saleor/saleor#9764 the accepted solution? I can help with a PR if any of this is a recommended solution.

@Ian2012
Copy link

Ian2012 commented Jul 22, 2022

That's the right solution. Please make a PR

@lkostrowski
Copy link
Member

Here is an issue that will fix it in the future
saleor/storefront#275

This PR updates Saleor packages, so it should also solve the problem
#158

@lkostrowski
Copy link
Member

#158 was merged, which means react-storefront was updated to the newest version.
It applies a fix for pnpm issue.

The issue should be solved, so I close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants