Upgrade to Saleor 3.5.x and introduce Make commands #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github has feature to copy code block. With dollar sign prefix, it can't be pasted & executed.
Add docs to Make, reorder localhost links
lkostrowski
requested review from
krzysztofwolski,
maarcingebala,
peelar and
patrys
magul
reviewed
Jul 28, 2022
| @@ -169,8 +169,6 @@ docker-compose down --volumes db | |||
| If you have any questions or feedback, do not hesitate to contact us via GitHub or Gitter: | |||
|
|
|||
| - https://github.com/saleor/saleor/discussions | |||
| - https://gitter.im/mirumee/saleor | |||
There was a problem hiding this comment.
why do we remove that? I thought it's still supported, I saw @karolkielecki comments there no more than month old.
There was a problem hiding this comment.
For better SEO/searchability, we are moving to Github discussions
krzysztofwolski
approved these changes
Jul 28, 2022
| @@ -0,0 +1,11 @@ | |||
| bootstrap: | |||
There was a problem hiding this comment.
Wonder if adding "cleanup" command would be a good idea? It would tear down the db and its volume.
There was a problem hiding this comment.
As discussed, @krzysztofwolski will open separate issue for it
peelar
approved these changes
Jul 28, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps submodules to 3.5.x versions.
Introduces Makefile for one-command scripts
Also, introduce some docs upgrades
Related to #157