-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(integrations & plugins): [sc-8971] Add nonce to Magento 2 inline script #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamstaz
requested review from
elliotlings,
StephenHonor,
JackGreen411,
brandonkyaw,
michaelbarley and
denizderman
May 15, 2024 10:05
JackGreen411
previously approved these changes
May 15, 2024
brandonkyaw
previously approved these changes
May 15, 2024
elliotlings
previously approved these changes
May 15, 2024
We need to bump all the version numbers, too, as noted in the SUBMITTING.md. |
Jamstaz
dismissed stale reviews from elliotlings, brandonkyaw, and JackGreen411
via
May 17, 2024 16:35
e8e64be
Version has been bumped to v1.4.11. |
elliotlings
previously approved these changes
May 17, 2024
elliotlings
approved these changes
May 20, 2024
JackGreen411
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.shortcut.com/salesfire/story/8971