fix invalid selector on core mixin #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @kaelig, @aputinski and @brandonferrua to be potential reviewers |
|
@kaelig can you have a look? |
|
Thank you so much for this, @3den. We've done a slightly more in-depth refactor of this part of SLDS, and will release a patch very soon, stay tuned! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Invalid CSS after "": expected selector, was ""Bug onscss/dependencies/core.scss#173Reviewer, please refer to this "definition of done" checklist:
Please confirm the following before accepting this PR:
*After accepting, please update the bower repo to include this fix