Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyphen (-) not a valid character for token names in Android? #158

Closed
morewry opened this issue Jun 29, 2018 · 2 comments
Closed

Hyphen (-) not a valid character for token names in Android? #158

morewry opened this issue Jun 29, 2018 · 2 comments

Comments

@morewry
Copy link

morewry commented Jun 29, 2018

I recently began working with our Android team on using the android.xml format. They've reported to me that - (hyphen) is not a valid character for names, e.g.

<color name="PROP-NAME">

Is not valid. I am using hyphens in our token names and the android.xml format output leaves them as hyphens. If hyphens aren't valid, I'd expect this format to remove them or change them to underscores, much like the module.js format changes names to camel case.

Be happy to PR that if it makes sense.

Slightly related, the android.xml format transforms token names to UPPERCASE. Why is that?

@aputinski
Copy link
Contributor

Yeah — a PR would be great. I'm planning on making a major release because there were several other breaking changes introduced for Android recently. As far as the name case, I'm not quite sure.

@morewry
Copy link
Author

morewry commented Jul 4, 2018

I won't touch the casing, then, for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants