Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Bloom Filter changes to support caching of metric schema before writing to ES #754

Merged
merged 22 commits into from
Jun 8, 2018

Conversation

dilipdevaraj-sfdc
Copy link
Contributor

No description provided.

@nkunal
Copy link
Contributor

nkunal commented Jun 6, 2018

hi

1 similar comment
@nkunal
Copy link
Contributor

nkunal commented Jun 6, 2018

hi

Copy link
Contributor

@nkunal nkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@codecov-io
Copy link

Codecov Report

Merging #754 into develop will increase coverage by 0.27%.
The diff coverage is 39.51%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #754      +/-   ##
=============================================
+ Coverage      38.92%   39.19%   +0.27%     
- Complexity      1968     1974       +6     
=============================================
  Files            290      290              
  Lines          17626    17644      +18     
  Branches        2493     2485       -8     
=============================================
+ Hits            6861     6916      +55     
+ Misses          9835     9793      -42     
- Partials         930      935       +5
Impacted Files Coverage Δ Complexity Δ
...gus/service/schema/ElasticSearchSchemaService.java 14.94% <23.31%> (+2.52%) 9 <4> (+5) ⬆️
...va/argus/service/schema/AbstractSchemaService.java 66.91% <70.58%> (+26.4%) 13 <6> (+2) ⬆️
...m/salesforce/dva/argus/service/DefaultService.java 72.72% <0%> (-9.1%) 5% <0%> (-1%)
...va/com/salesforce/dva/argus/system/SystemMain.java 84.61% <0%> (-2.57%) 17% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a8e44f...5d5393f. Read the comment docs.

Copy link
Contributor

@nkunal nkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dilipdevaraj-sfdc
Copy link
Contributor Author

@kgowdru
PR has been approved by nkunal. But he does not have write access. Can you add nkunal as member.
If PR looks good to you can you approve it so I can merge it.

@rajsarkapally rajsarkapally self-requested a review June 8, 2018 04:36
@rajsarkapally
Copy link
Contributor

@dilip-devaraj approved

@dilipdevaraj-sfdc dilipdevaraj-sfdc merged commit a85c5ca into salesforce:develop Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants