-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluators check for empty data #178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… separate file: EvaluationMetrics.scala - Added checks for empty data in Evaluators factory, which return defaults in case of no data was provided
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
- Coverage 86.33% 86.33% -0.01%
==========================================
Files 305 307 +2
Lines 9976 9971 -5
Branches 343 542 +199
==========================================
- Hits 8613 8608 -5
Misses 1363 1363
Continue to review full report at Codecov.
|
leahmcguire
reviewed
Nov 8, 2018
core/src/main/scala/com/salesforce/op/evaluators/EvaluationMetrics.scala
Show resolved
Hide resolved
leahmcguire
reviewed
Nov 8, 2018
core/src/main/scala/com/salesforce/op/evaluators/Evaluators.scala
Outdated
Show resolved
Hide resolved
leahmcguire
reviewed
Nov 8, 2018
core/src/main/scala/com/salesforce/op/evaluators/OpBinaryClassificationEvaluator.scala
Outdated
Show resolved
Hide resolved
kinfaikan
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Most of our evaluators never check for empty during
evaluate
call and fail miserably.Describe the proposed solution
Evaluators
factory, which return defaults in case of no data was providedEvaluators
factoryEvaluatorsTest
to use property based testing with Tables. Each evaluators is now being evaluated against non empty and an empty dataset.brierScore
->BrierScore
Describe alternatives you've considered
NA
Additional context
Follows up on PR #176