Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse geocoder with Lucene #227

Closed
wants to merge 11 commits into from
Closed

Reverse geocoder with Lucene #227

wants to merge 11 commits into from

Conversation

tovbinm
Copy link
Collaborator

@tovbinm tovbinm commented Feb 15, 2019

Related issues
#154

Describe the proposed solution
Reverse geocoder implementation with Lucene index with GeohashPrefixTree and RecursivePrefixTreeStrategy.

TBD

Describe alternatives you've considered
TBD

@tovbinm tovbinm changed the title Mt/geo reverse Reverse geocoder with Lucene Feb 15, 2019
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #227 into master will increase coverage by 7.36%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage    79.1%   86.46%   +7.36%     
==========================================
  Files         312      313       +1     
  Lines       10183    10253      +70     
  Branches      335      558     +223     
==========================================
+ Hits         8055     8865     +810     
+ Misses       2128     1388     -740
Impacted Files Coverage Δ
...a/com/salesforce/op/utils/text/OpenNLPModels.scala 97.61% <ø> (ø) ⬆️
...main/scala/com/salesforce/op/test/TestCommon.scala 52.63% <100%> (+2.63%) ⬆️
...alesforce/op/utils/geo/LuceneReverseGeocoder.scala 95.65% <95.65%> (ø)
...op/stages/impl/regression/OpXGBoostRegressor.scala 18.18% <0%> (+2.27%) ⬆️
...p/evaluators/OpBinaryClassificationEvaluator.scala 82.5% <0%> (+2.5%) ⬆️
.../main/scala/com/salesforce/op/OpWorkflowCore.scala 93.54% <0%> (+3.22%) ⬆️
...ala/com/salesforce/op/dsl/RichNumericFeature.scala 100% <0%> (+3.75%) ⬆️
...main/scala/com/salesforce/op/OpWorkflowModel.scala 92.85% <0%> (+4.28%) ⬆️
...scala/com/salesforce/op/testkit/RandomStream.scala 100% <0%> (+4.76%) ⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 689c867...8ba16f6. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #227 into master will decrease coverage by 27.12%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #227       +/-   ##
===========================================
- Coverage   86.39%   59.27%   -27.13%     
===========================================
  Files         312      313        +1     
  Lines       10182    10252       +70     
  Branches      333      559      +226     
===========================================
- Hits         8797     6077     -2720     
- Misses       1385     4175     +2790
Impacted Files Coverage Δ
...a/com/salesforce/op/utils/text/OpenNLPModels.scala 97.61% <ø> (ø) ⬆️
...alesforce/op/utils/geo/LuceneReverseGeocoder.scala 0% <0%> (ø)
...sforce/op/stages/base/binary/BinaryEstimator.scala 0% <0%> (-100%) ⬇️
...ce/op/stages/impl/feature/TextLenTransformer.scala 0% <0%> (-100%) ⬇️
...n/scala/com/salesforce/op/readers/CSVReaders.scala 0% <0%> (-100%) ⬇️
...stages/base/sequence/BinarySequenceEstimator.scala 0% <0%> (-100%) ⬇️
.../scala/com/salesforce/op/readers/CSVDefaults.scala 0% <0%> (-100%) ⬇️
...lesforce/op/stages/impl/feature/LangDetector.scala 0% <0%> (-100%) ⬇️
...sql/execution/datasources/csv/CSVSchemaUtils.scala 0% <0%> (-100%) ⬇️
...alesforce/op/cli/gen/templates/SimpleProject.scala 0% <0%> (-100%) ⬇️
... and 142 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0af563...d11d023. Read the comment docs.

@tovbinm tovbinm mentioned this pull request Jul 11, 2019
@tovbinm tovbinm closed this Aug 15, 2019
@tovbinm tovbinm deleted the mt/geo-reverse branch November 26, 2019 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant