feat(store,storeconfig): config for deepFreeze function #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds deepFreezeFunction in StoreConfigOptions and unit tests for feature Can use custom deepFreeze for complex objects in store Resolves salesforce#124
NetanelBasal
requested changes
Apr 17, 2019
akita/src/storeConfig.ts
Outdated
| @@ -4,6 +4,7 @@ export type StoreConfigOptions = { | |||
| idKey?: string; | |||
| storeName?: string; | |||
| cache?: { ttl: number }; | |||
| deepFreezeFunction?: (o: any) => any; | |||
There was a problem hiding this comment.
Can you change it to deepFreezeFn, please?
NetanelBasal
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds deepFreezeFunction in StoreConfigOptions and unit tests for feature
Can use custom deepFreeze for complex objects in store
Resolves #124
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Objects in store are frozen with deepFreeze on _setState. Complex states or entities might break when frozen (like moment.js) during development.
Issue Number: #124
What is the new behavior?
User can now add a custom deepFreeze function to dictate Freezing behavior during development.
Does this PR introduce a breaking change?
Other information
Also added a simple unit test for deepFreeze function. Where do I update docs?