Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better path pattern matching #111

Merged
merged 3 commits into from
Aug 17, 2018
Merged

fix: better path pattern matching #111

merged 3 commits into from
Aug 17, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Jul 3, 2018

Details

The current pattern matching is very ambiguous since its relative to the project.
Instead allow a similar approach to best where the pattern matching is more generic

Example: Run test within this folder

best examples/simple_benchmark/

Example: Run test with a particular glob

best **/object_keys.*

@diervo diervo requested a review from pmdartus July 3, 2018 23:32
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 9243159 | Target commit: 693593f

simple-benchmark-prod

object_keys metric base(9243159) target(693593f) trend
stringify_parse duration 35.10 (± 0.30 ms) 36.35 (± 0.35 ms) -3.56% 👎
deep_merge duration 26.30 (± 0.95 ms) 27.95 (± 1.20 ms) -6.27% 👎

simple-benchmark-compat

object_keys metric base(9243159) target(693593f) trend
stringify_parse duration 34.70 (± 0.40 ms) 36.30 (± 0.70 ms) -4.61% 👎
deep_merge duration 114.20 (± 2.30 ms) 117.00 (± 5.30 ms) -2.45% 👌

lwc-examples-prod

simple-item metric base(9243159) target(693593f) trend
create_and_render duration 51.10 (± 0.70 ms) 55.90 (± 1.80 ms) -9.39% 👎

lwc-examples-compat

simple-item metric base(9243159) target(693593f) trend
create_and_render duration 84.90 (± 1.10 ms) 95.90 (± 6.30 ms) -12.96% 👎

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 9243159 | Target commit: b646839

simple-benchmark-prod

object_keys metric base(9243159) target(b646839) trend
stringify_parse duration 35.10 (± 0.30 ms) 35.15 (± 0.25 ms) -0.14% 👌
deep_merge duration 26.30 (± 0.95 ms) 25.95 (± 0.65 ms) 1.33% 👍

simple-benchmark-compat

object_keys metric base(9243159) target(b646839) trend
stringify_parse duration 34.70 (± 0.40 ms) 34.55 (± 0.30 ms) 0.43% 👌
deep_merge duration 114.20 (± 2.30 ms) 115.90 (± 2.45 ms) -1.49% 👌

lwc-examples-prod

simple-item metric base(9243159) target(b646839) trend
create_and_render duration 51.10 (± 0.70 ms) 51.50 (± 0.80 ms) -0.78% 👎

lwc-examples-compat

simple-item metric base(9243159) target(b646839) trend
create_and_render duration 84.90 (± 1.10 ms) 86.00 (± 1.10 ms) -1.30% 👎

Copy link
Member

@pmdartus pmdartus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to add extra comments.

}

const patterns = nonFlagArgs.map(p => {
if (p.includes('*')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments to explain the different branches.

Copy link
Member

@pmdartus pmdartus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to add extra comments.

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 9243159 | Target commit: 2d6b076

simple-benchmark-prod

object_keys metric base(9243159) target(2d6b076) trend
stringify_parse duration 35.10 (± 0.30 ms) 36.20 (± 0.60 ms) -3.13% 👎
deep_merge duration 26.30 (± 0.95 ms) 28.50 (± 2.80 ms) -8.37% 👎

simple-benchmark-compat

object_keys metric base(9243159) target(2d6b076) trend
stringify_parse duration 34.70 (± 0.40 ms) 35.45 (± 0.55 ms) -2.16% 👎
deep_merge duration 114.20 (± 2.30 ms) 119.30 (± 5.20 ms) -4.47% 👎

lwc-examples-prod

simple-item metric base(9243159) target(2d6b076) trend
create_and_render duration 51.10 (± 0.70 ms) 54.60 (± 1.50 ms) -6.85% 👎

lwc-examples-compat

simple-item metric base(9243159) target(2d6b076) trend
create_and_render duration 84.90 (± 1.10 ms) 91.65 (± 2.70 ms) -7.95% 👎

@diervo diervo merged commit 6294d67 into master Aug 17, 2018
@diervo diervo deleted the dval/fixPaths branch August 17, 2018 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants