-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: better path pattern matching #111
Conversation
Benchmark resultsBase commit: simple-benchmark-prod
simple-benchmark-compat
lwc-examples-prod
lwc-examples-compat
|
Benchmark resultsBase commit: simple-benchmark-prod
simple-benchmark-compat
lwc-examples-prod
lwc-examples-compat
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need to add extra comments.
packages/best-cli/src/run_best.js
Outdated
} | ||
|
||
const patterns = nonFlagArgs.map(p => { | ||
if (p.includes('*')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comments to explain the different branches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need to add extra comments.
Benchmark resultsBase commit: simple-benchmark-prod
simple-benchmark-compat
lwc-examples-prod
lwc-examples-compat
|
Details
The current pattern matching is very ambiguous since its relative to the project.
Instead allow a similar approach to best where the pattern matching is more generic
Example: Run test within this folder
Example: Run test with a particular glob