Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsing error timeout #121

Merged
merged 3 commits into from
Sep 3, 2018
Merged

fix: parsing error timeout #121

merged 3 commits into from
Sep 3, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Sep 3, 2018

Details

If an error is thrown at benchmark evaluation time, agent will get stacked in a infinite loop.

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

salesforce-best-lwc-internal bot commented Sep 3, 2018

Benchmark results

Base commit: 27aad3e | Target commit: bb7a92e

simple-benchmark-prod

   object_keys    metric base(27aad3e) target(bb7a92e) trend
stringify_parse duration 38.65 (± 1.65 ms) 37.50 (± 0.80 ms) 2.98% 👍
deep_merge duration 30.80 (± 3.50 ms) 28.60 (± 2.90 ms) 7.14% 👍

simple-benchmark-compat

object_keys metric base(27aad3e) target(bb7a92e) trend
stringify_parse duration 35.30 (± 0.50 ms) 36.15 (± 0.85 ms) -2.41% 👎
deep_merge duration 115.60 (± 3.50 ms) 126.40 (± 8.75 ms) -9.34% 👎

lwc-examples-prod

simple-item metric base(27aad3e) target(bb7a92e) trend
create_and_render duration 54.20 (± 1.70 ms) 55.65 (± 1.85 ms) -2.68% 👎

lwc-examples-compat

simple-item metric base(27aad3e) target(bb7a92e) trend
create_and_render duration 90.20 (± 3.20 ms) 94.50 (± 4.10 ms) -4.77% 👎

@diervo diervo merged commit d283352 into master Sep 3, 2018
@diervo diervo deleted the dval/fixParsingErrTimeout branch September 3, 2018 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant