Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added option to ignore test paths via config #123

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

dbajric
Copy link
Contributor

@dbajric dbajric commented Sep 18, 2018

Details

This change allows ignore patterns to be specified in the config file. When patterns are specified, any benchmark file or folder that matches will be excluded from running the test.

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: ecef58e | Target commit: d310f79

simple-benchmark-prod

object_keys metric base(ecef58e) target(d310f79) trend
stringify_parse duration 36.00 (±0.40 ms) 37.00 (±0.60 ms) +1.0ms (2.8%) 👎
deep_merge duration 28.40 (±0.60 ms) 30.30 (±1.50 ms) +1.9ms (6.7%) 👎

simple-benchmark-compat

object_keys metric base(ecef58e) target(d310f79) trend
stringify_parse duration 36.90 (±0.70 ms) 36.00 (±0.40 ms) -0.9ms (2.4%) 👍
deep_merge duration 107.95 (±4.40 ms) 105.60 (±3.20 ms) -2.4ms (2.2%) 👍

lwc-examples-prod

simple-item metric base(ecef58e) target(d310f79) trend
create_and_render duration 52.90 (±1.10 ms) 53.50 (±1.00 ms) +0.6ms (1.1%) 👎

lwc-examples-compat

simple-item metric base(ecef58e) target(d310f79) trend
create_and_render duration 93.90 (±2.80 ms) 91.20 (±1.30 ms) -2.7ms (2.9%) 👍

@diervo diervo merged commit d9d61a9 into master Sep 18, 2018
@diervo diervo deleted the dbajric/ignore-path branch September 18, 2018 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants