Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: adding rollup cache for massive improvement of builds #125

Merged
merged 3 commits into from
Sep 21, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Sep 21, 2018

Details

Allow rollup to cache per project (or rollup configuration)
This allow for a massive improvement while building

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: ac254c5 | Target commit: 3e1c754

simple-benchmark-prod

object_keys metric base(ac254c5) target(3e1c754) trend
stringify_parse duration 35.80 (±0.30 ms) 35.50 (±0.20 ms) -0.3ms (0.8%) 👍
deep_merge duration 28.80 (±0.60 ms) 28.00 (±0.60 ms) -0.8ms (2.8%) 👍

simple-benchmark-compat

object_keys metric base(ac254c5) target(3e1c754) trend
stringify_parse duration 36.10 (±0.80 ms) 35.00 (±0.30 ms) -1.1ms (3.0%) 👍
deep_merge duration 105.30 (±3.90 ms) 99.70 (±2.20 ms) -5.6ms (5.3%) 👍

lwc-examples-prod

simple-item metric base(ac254c5) target(3e1c754) trend
create_and_render duration 53.70 (±1.50 ms) 53.10 (±2.10 ms) -0.6ms (1.1%) 👌

lwc-examples-compat

simple-item metric base(ac254c5) target(3e1c754) trend
create_and_render duration 96.90 (±4.35 ms) 165.20 (±9.60 ms) +68.3ms (70.5%) 👎

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: ac254c5 | Target commit: 0c60943

simple-benchmark-prod

object_keys metric base(ac254c5) target(0c60943) trend
stringify_parse duration 35.80 (±0.30 ms) 35.50 (±0.40 ms) -0.3ms (0.8%) 👍
deep_merge duration 28.80 (±0.60 ms) 28.70 (±0.70 ms) -0.1ms (0.3%) 👌

simple-benchmark-compat

object_keys metric base(ac254c5) target(0c60943) trend
stringify_parse duration 36.10 (±0.80 ms) 35.70 (±0.40 ms) -0.4ms (1.1%) 👍
deep_merge duration 105.30 (±3.90 ms) 105.90 (±2.20 ms) +0.6ms (0.6%) 👌

lwc-examples-prod

simple-item metric base(ac254c5) target(0c60943) trend
create_and_render duration 53.70 (±1.50 ms) 53.70 (±2.50 ms) 0.0ms (0.0%) 👌

lwc-examples-compat

simple-item metric base(ac254c5) target(0c60943) trend
create_and_render duration 96.90 (±4.35 ms) 95.15 (±3.35 ms) -1.8ms (1.8%) 👌

@diervo diervo merged commit fab2c91 into master Sep 21, 2018
@diervo diervo deleted the dval/rollupCaching branch September 21, 2018 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants