Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade rollup to fix wrong mangling #126

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Sep 24, 2018

Details

Upgrade rollup to a version that has the fix for mangled identifiers

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: a549114 | Target commit: d8d0856

simple-benchmark-prod

object_keys metric base(a549114) target(d8d0856) trend
stringify_parse duration 37.30 (±0.70 ms) 36.20 (±0.50 ms) -1.1ms (2.9%) 👍
deep_merge duration 31.10 (±1.80 ms) 29.00 (±1.10 ms) -2.1ms (6.8%) 👍

simple-benchmark-compat

object_keys metric base(a549114) target(d8d0856) trend
stringify_parse duration 36.60 (±0.65 ms) 36.40 (±0.70 ms) -0.2ms (0.5%) 👍
deep_merge duration 107.30 (±4.30 ms) 103.50 (±3.15 ms) -3.8ms (3.5%) 👍

lwc-examples-prod

simple-item metric base(a549114) target(d8d0856) trend
create_and_render duration 54.80 (±2.20 ms) 54.70 (±1.60 ms) -0.1ms (0.2%) 👌

lwc-examples-compat

simple-item metric base(a549114) target(d8d0856) trend
create_and_render duration 97.60 (±4.00 ms) 93.90 (±3.10 ms) -3.7ms (3.8%) 👍

@diervo diervo merged commit bdca3f6 into master Sep 24, 2018
@diervo diervo deleted the dval/upgradeRollup branch September 24, 2018 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants