feat: Proxy Support #177
Merged
feat: Proxy Support #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonsilberman
requested review from
diervo,
jodarove,
nolanlawson and
pmdartus
as code owners
jodarove
reviewed
Jul 23, 2019
jodarove
reviewed
Jul 23, 2019
jodarove
reviewed
Jul 23, 2019
diervo
approved these changes
Jul 24, 2019
added 14 commits
July 24, 2019 13:51
jasonsilberman
force-pushed
the
jsilberman/proxy
branch
from
7593534
to
f08d936
Compare
🥳 Performance ImprovementBest has detected that there is a Please click here to see more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR introduces support to the hub to connect to an agent through a proxy. This is needed to run the hub inside of PRD.
The proxy support can be turned on by setting
process.env.HTTP_PROXY.Also this PR includes:
Does this PR introduce a breaking change?
No.