Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Identical hash commits should skip comparison #19

Merged
merged 1 commit into from
Jan 7, 2018
Merged

fix: Identical hash commits should skip comparison #19

merged 1 commit into from
Jan 7, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Jan 7, 2018 •
edited
Loading

  • Guard for identical hashes
  • Remove console log

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: b80629f | Target commit: 0197fa7

benchmark base(0197fa7) target(b80629f) trend
simple-item.benchmark:create_and_render 90.45 (± 4.42 ms) 78.87 (± 4.42 ms) 👍

@diervo diervo merged commit 38f1911 into master Jan 7, 2018
@diervo diervo deleted the dval/guardingCompare branch January 7, 2018 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@diervo