feat: add statistic tracking to agent-hub #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineedfat
requested review from
diervo,
jasonsilberman,
jodarove,
nolanlawson and
pmdartus
as code owners
jodarove
reviewed
Oct 2, 2019
packages/@best/agent-frontend/src/client/modules/view/dashboard/dashboard.css
Outdated
Show resolved
Hide resolved
diervo
suggested changes
Oct 8, 2019
packages/@best/agent-frontend/src/client/modules/view/dashboard/dashboard.js
Outdated
Show resolved
Hide resolved
| private addStatusChangeListener = (agent: Agent) => { | ||
| agent.on('status-changed', ({ newValue }: { newValue: AgentStatus }) => { | ||
| if (newValue === AgentStatus.Idle) { | ||
| this.emit('idle-agent', agent); | ||
| } else if (newValue === AgentStatus.Offline) { | ||
| setTimeout(() => { |
There was a problem hiding this comment.
@jodarove can you triple check this logic make sure it makes sense from within the algorithm you created?
@diervo I do not have permission to merge into the repository, so I'll need someone to hit that merge button once it is time to merge with all the required approval. |
|
I will release something EOD |
|
Thank you @ineedfat!! Keep them coming :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Added stats tracking with StatsManager to agent-hub:
For now it begins tracking statistics like number of active/pending clients, total jobs in queue, and active/idle/offline agents by listening to specific log events. This will give us better insight into the server load, and therefore, be able to autoscale better in the cloud.
Added new behavior to remove agents that are offline for more than 30 minutes:
Previously, agent-hub has no way to remove offline clients, and after discussing with Jose, I've introduced a new behavior to remove clients that are offline for more than 30 minutes.
Modified front-end to display the new stats introduced by StatsManager
Does this PR introduce a breaking change?