feat: add latest webdriverIO runner #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineedfat
requested review from
diervo,
jasonsilberman,
jodarove,
nolanlawson and
pmdartus
as code owners
jodarove
reviewed
Oct 15, 2019
| @@ -19,7 +19,7 @@ | |||
| { "path": "./packages/@best/runner-headless" }, | |||
| { "path": "./packages/@best/runner-remote" }, | |||
| { "path": "./packages/@best/runner-hub" }, | |||
| // { "path": "./packages/@best/runner-webdriver" }, | |||
jodarove
reviewed
Oct 15, 2019
| return { results, environment, benchmarkInfo, projectConfig }; | ||
| } catch (e) { | ||
| runnerLogStream.onBenchmarkError(benchmarkEntry); | ||
| throw e; |
There was a problem hiding this comment.
should we await browser.close() and terminate() before throwing?
There was a problem hiding this comment.
I don't it it really matters
diervo
approved these changes
Oct 16, 2019
diervo
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds runner-webdriverIO to support the latest webdriverIO (v5) whereas the previous runner-webdriver was based on an older version webdriverIO(v4).
The new webdriver runner implementation is consistent with the existing runner-headless minus the tracing ability (simply because we are supporting multiple browsers).
Tested the new runner with Best running locally and behind agent-hub against Selenium-Standalone-Server with both chromedriver and geckodriver.
Possible future improvement:
Ideally, it would be best if we can run webdriverIO using client -> agent-hub -> agent (runner-remote) -> runner-webdriverIO. This would allow us to use the agent-hub for scaling and the runner-remote agent as a broker to run different runners, but currently it's somewhat complex to implement this with the current implementation. :D
Does this PR introduce a breaking change?