feat: rewrite of Agents, Hubs, Remotes and Algo #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
February 3, 2020 19:44
diervo
requested review from
jasonsilberman,
jodarove,
nolanlawson and
pmdartus
as code owners
diervo
changed the title
diervo
changed the title
|
I don't expect anyone to do a full review, but just FYI :) |
diervo
commented
Feb 13, 2020
| connectedCallback() { | ||
| const socket = connect(host, socketConfig); | ||
|
|
||
| socket.on(BEST_RPC.AGENT_STATE, this.onAgentState.bind(this)); |
There was a problem hiding this comment.
@ineedfat now you can trivially subscribe via websocket to all events on the hub or agent, so you can spin more machines at will
added 20 commits
February 13, 2020 14:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
A complete rewrite of the connectivity layer.
Does this PR introduce a breaking change?