Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): configurable main branch #259

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

rlodico
Copy link
Contributor

@rlodico rlodico commented Nov 19, 2020

Details

Enables the main branch name to be configurable so snapshots from branches other than master can be non-temporary.

Does this PR introduce a breaking change?

  • Yes
  • No

Note: I made master the default branch for seamless backwards compatibility, but we may eventually want to forgo that since the default branch on Github has changed from master to main. Thoughts on doing that now?

Another slightly more seamless transition might be to have mainBranch be nullable, and if undefined it accepts both master and main as non-temporary branches in store.ts#L86 (more complicated, but supports both):

    temporary: globalConfig.mainBranch
        ? (globalConfig.mainBranch !== branch)
        : ('master' !== branch && 'main' !== branch)

@diervo diervo merged commit f27a8bc into salesforce:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants