feat(config): configurable main branch #259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Enables the main branch name to be configurable so snapshots from branches other than
master
can be non-temporary.Does this PR introduce a breaking change?
Note: I made
master
the default branch for seamless backwards compatibility, but we may eventually want to forgo that since the default branch on Github has changed frommaster
tomain
. Thoughts on doing that now?Another slightly more seamless transition might be to have
mainBranch
be nullable, and if undefined it accepts bothmaster
andmain
as non-temporary branches instore.ts#L86
(more complicated, but supports both):