fix: enable cross-origin isolation #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sf-v
approved these changes
Apr 26, 2022
sf-v
reviewed
Apr 26, 2022
|
Thank you, @nolanlawson! Note: Updated the tests and merged this in 81baf5d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
As described in this post, enabling cross-origin isolation should give us more fine-grained and consistent timings from
performance.now(),performance.mark(), etc.I didn't see a good place to add tests, but let me know if there is one, and I'd be happy to add it. The main outcome is that we want
window.crossOriginIsolatedto be true in the browser.Does this PR introduce a breaking change?