Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(best-frontend): Fix naming #68

Merged
merged 1 commit into from
Feb 6, 2018
Merged

feat(best-frontend): Fix naming #68

merged 1 commit into from
Feb 6, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Feb 6, 2018

Details

Wrong naming for displaying

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: 6159192 | Target commit: 3558f8b

benchmark base(6159192) target(3558f8b) trend
object_keys.benchmark:stringify_parse 0.28 (± 0.03 ms) 0.48 (± 0.03 ms) 👎
object_keys.benchmark:deep_merge 0.32 (± 0.03 ms) 0.53 (± 0.03 ms) 👎
simple-item.benchmark:create_and_render 60.77 (± 1.95 ms) 64.91 (± 1.95 ms) 👎

@diervo diervo merged commit 013b196 into master Feb 6, 2018
@diervo diervo deleted the dval/fixBenchmarkNames branch February 6, 2018 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@diervo