Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(commit): add commit validation #94

Merged
merged 1 commit into from
Mar 18, 2018
Merged

feat(commit): add commit validation #94

merged 1 commit into from
Mar 18, 2018

Conversation

apapko
Copy link
Contributor

@apapko apapko commented Mar 15, 2018

Details

Add semantic commit validation ( sync with master )

Does this PR introduce a breaking change?

  • Yes
  • No

@apapko apapko requested a review from diervo March 15, 2018 18:11
@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: 5cb6c76 | Target commit: 951aa9c

object_keys (simple-benchmarks) base(5cb6c76) target(951aa9c) trend
stringify_parse 35.50 (± 0.25 ms) 36.60 (± 0.20 ms) -3.10% 👎
deep_merge 25.40 (± 1.40 ms) 27.85 (± 1.10 ms) -9.65% 👎
simple-item (lwc-examples-prod) base(5cb6c76) target(951aa9c) trend
create_and_render 54.50 (± 1.60 ms) 51.30 (± 0.60 ms) 5.87% 👍
simple-item (lwc-examples-compat) base(5cb6c76) target(951aa9c) trend
create_and_render 87.75 (± 1.35 ms) 85.90 (± 1.10 ms) 2.11% 👍

@diervo diervo merged commit e1bdbb7 into master Mar 18, 2018
@diervo diervo deleted the apapko/add-commit-validation branch March 18, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diervo diervo Awaiting requested review from diervo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apapko @diervo