Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor git and cli table display #97

Merged
merged 13 commits into from
Mar 19, 2018
Merged

feat: Refactor git and cli table display #97

merged 13 commits into from
Mar 19, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Mar 19, 2018

Details

Produces better output both on git replies and on the CLI.

Does this PR introduce a breaking change?

  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 5781d55 | Target commit: 8fe6741

simple-benchmarks

object_keys metric base(5781d55) target(8fe6741) trend
stringify_parse duration 36.00 (± 0.10 ms) 36.50 (± 0.70 ms) -1.39% 👎
deep_merge duration 25.30 (± 0.50 ms) 28.15 (± 2.25 ms) -11.26% 👎

lwc-examples-prod

simple-item metric base(5781d55) target(8fe6741) trend
create_and_render duration 50.00 (± 0.50 ms) 50.60 (± 0.70 ms) -1.20% 👎

lwc-examples-compat

simple-item metric base(5781d55) target(8fe6741) trend
create_and_render duration 83.90 (± 0.70 ms) 86.30 (± 2.00 ms) -2.86% 👎

@diervo diervo merged commit 0fc095f into master Mar 19, 2018
@diervo diervo deleted the dval/tableDisplay branch March 19, 2018 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant