Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allowing custom runner configs #99

Merged
merged 2 commits into from
Mar 22, 2018
Merged

feat: Allowing custom runner configs #99

merged 2 commits into from
Mar 22, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Mar 22, 2018

Details

Also fixed a bunch of issues with best-agent

Does this PR introduce a breaking change?

  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: f2898e6 | Target commit: 4273617

simple-benchmarks

object_keys metric base(f2898e6) target(4273617) trend
stringify_parse duration 36.10 (± 0.40 ms) 35.80 (± 0.30 ms) 0.83% 👍
deep_merge duration 28.00 (± 1.10 ms) 25.80 (± 0.60 ms) 7.86% 👍

lwc-examples-prod

simple-item metric base(f2898e6) target(4273617) trend
create_and_render duration 54.00 (± 1.30 ms) 51.25 (± 0.65 ms) 5.09% 👍

lwc-examples-compat

simple-item metric base(f2898e6) target(4273617) trend
create_and_render duration 94.60 (± 5.10 ms) 87.50 (± 1.50 ms) 7.51% 👍

@diervo diervo merged commit 6b7a8ef into master Mar 22, 2018
@diervo diervo deleted the dval/fixingErrors branch March 22, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant