Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all console.errors to console.warns #3692

Open
nolanlawson opened this issue Aug 30, 2023 · 0 comments
Open

Change all console.errors to console.warns #3692

nolanlawson opened this issue Aug 30, 2023 · 0 comments
Labels
Up for grabs Issues that are relatively small, self-contained, and ready for implementation

Comments

@nolanlawson
Copy link
Collaborator

People commonly see "errors" like this:

Error: [LWC error]: The `appendChild` method is available only on elements that use the `lwc:dom="manual"` directive.

... and they assume this is related to some other error. In fact, it's basically a warning, because we continue rendering regardless. But because it's red, it looks like an error.

We should replace all logError calls with logWarn. If we're going to log something and not throw an Error, then the text should be yellow rather than red.

@nolanlawson nolanlawson added the Up for grabs Issues that are relatively small, self-contained, and ready for implementation label Aug 30, 2023
yashpatel1998 added a commit to yashpatel1998/lwc that referenced this issue Sep 5, 2023
nolanlawson added a commit that referenced this issue Sep 29, 2023
Co-authored-by: Nolan Lawson <nlawson@salesforce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Up for grabs Issues that are relatively small, self-contained, and ready for implementation
Projects
None yet
Development

No branches or pull requests

1 participant