refactor(engine): remove Event instanceof check on dispatchEvent #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmdartus
commented
Dec 12, 2019
caridy
reviewed
Dec 12, 2019
|
Discussion with @caridy:
|
pmdartus
changed the title
caridy
reviewed
Dec 13, 2019
caridy
reviewed
Dec 13, 2019
caridy
reviewed
Dec 13, 2019
caridy
reviewed
Dec 13, 2019
caridy
reviewed
Dec 13, 2019
caridy
reviewed
Dec 13, 2019
pmdartus
force-pushed
the
pmdartus/remove-instance-of
branch
from
56ea794
to
300ccf6
Compare
caridy
reviewed
Dec 17, 2019
| if (!isNull(event) && isObject(event)) { | ||
| const { type } = event; | ||
|
|
||
| if (isString(type) && !/^[a-z][a-z0-9_]*$/.test(type)) { |
There was a problem hiding this comment.
I think this condition is incorrect, type should be a string, and a valid one, otherwise throw.
caridy
suggested changes
Dec 17, 2019
pmdartus
force-pushed
the
pmdartus/remove-instance-of
branch
from
d67745f
to
bca5822
Compare
|
@caridy Ready for another pass of review. |
caridy
approved these changes
Jan 6, 2020
ekashida
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
In the process of implementing SSR (#910), to start decoupling the engine from the DOM. This PR remove the
instanceof Eventcheck inLigthningElement.prototype.dispatchEvent. The same check is run by the browser when invoking theEventTarget.prototype.dispatchEventmethod.Does this PR introduce breaking changes?
No, it does not introduce breaking changes.If yes, please describe the impact and migration path for existing applications.
The PR fulfills these requirements: