Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(integration-karma): re-enable window listener test #1668

Merged
merged 2 commits into from
Jan 13, 2020
Merged

test(integration-karma): re-enable window listener test #1668

merged 2 commits into from
Jan 13, 2020

Conversation

pmdartus
Copy link
Member

@pmdartus pmdartus commented Jan 13, 2020 •
edited
Loading

Details

Fixes #1277.
This test is one of the top failing tests in the compat-integration build step.

Does this PR introduce breaking changes?

  • ✅ No, it does not introduce breaking changes.

If yes, please describe the impact and migration path for existing applications.

The PR fulfills these requirements:

  • Have tests for the proposed changes been added? ✅
  • Have you followed these instructions to clearly describe the issue being fixed or feature enhanced? ✅

GUS work item

W-7093447 & W-7107506

@pmdartus pmdartus merged commit 82c97f1 into master Jan 13, 2020
@pmdartus pmdartus deleted the pmdartus/enable-1277 branch January 13, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapko apapko apapko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable window event listener karma test once Sauce Labs supports Safari version >= 12.0.1
2 participants
@pmdartus @apapko