Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(synthetic-shadow): refine the delegates focus selector #1709

Merged
merged 13 commits into from
Feb 12, 2020

Conversation

ekashida
Copy link
Member

@ekashida ekashida commented Feb 7, 2020

Details

  • Add integration test for focus-delegation-selector coverage
  • Tighten the [href] query to a[href] and area[href]
  • Add iframe

Does this PR introduce breaking changes?

  • No, it does not introduce breaking changes.

The PR fulfills these requirements:

  • Have tests for the proposed changes been added? ✅
  • Have you followed these instructions to clearly describe the issue being fixed or feature enhanced? ✅

GUS work item

W-5999773

Copy link
Contributor

@caridy caridy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekashida ekashida force-pushed the ekashida/delegates-focus-selector branch 3 times, most recently from f668c01 to 806556a Compare February 11, 2020 05:29
- detailsEmpty, summaryInsideDetails, summaryInsideDetailsMultiple: difficult to target via selector
- embedSrc, objectData: causes the test to hang
- iframeSrc: requires two tabs for some reason
- svgAnchorXlinkHref: difficult to target via selector (only a[xlink:href] inside an svg)
@ekashida ekashida force-pushed the ekashida/delegates-focus-selector branch from fe62457 to 6ef4eb2 Compare February 11, 2020 06:00
@ekashida ekashida merged commit 8b0302b into master Feb 12, 2020
@ekashida ekashida deleted the ekashida/delegates-focus-selector branch February 12, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants