refactor(engine): remove dependency on Element.prototype.tagName #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravijayaramappa
approved these changes
May 30, 2020
caridy
reviewed
Jun 4, 2020
| @@ -116,6 +116,7 @@ export function createElement( | |||
| setElementProto(element, def); | |||
|
|
|||
| createVM(element, def, { | |||
| tagName: sel, | |||
There was a problem hiding this comment.
I'm concern that if someone is doing createElement('x-Foo', { is: Foo }), it will ended being an invalid tagName here. For WC we extract it from the element and lowercase it; when from the compiled template, it is probably safer, and always coming as lowercase, but our own createElement do not lowercase it.
There was a problem hiding this comment.
Discussed offline and agreed to leave this as-is for now since we couldn't think of a scenario where it would make a difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR removes the dependency on
Element.prototype.tagNameto look up the component name. The tag name is now stored directly on theVM.Does this PR introduce breaking changes?
No, it does not introduce breaking changes.If yes, please describe the impact and migration path for existing applications.
The PR fulfills these requirements:
GUS work item
W-7552459