fix(engine-server): Dynamic style generation #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmdartus
changed the title
| get(target, property) { | ||
| get(target, property): string { | ||
| let value: string; | ||
|
|
||
| const styleAttribute = getStyleAttribute(); |
There was a problem hiding this comment.
Not a change made in this pr, but may be you can take care of it here
getStyleAttribute() has this element.attributes.find. element.attributes returns a NamedNodeMap. NamedNodeMap does not have a find method on it.
There was a problem hiding this comment.
@ravijayaramappa We're actually interacting with our DOM polyfill here, it's probably helpful to look at the types defined in https://github.com/salesforce/lwc/blob/master/packages/@lwc/engine-server/src/types.ts
ravijayaramappa
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes, dynamic style property generation on SSR. For dynamic style, the engine core uses
cssTexton the StyleDeclaration to set the style property content.Does this PR introduce breaking changes?
No, it does not introduce breaking changes.The PR fulfills these requirements:
GUS work item
W-7552550