fix: throw error if Rollup version is too old #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this manually by downgrading Rollup, and it throws an error like: |
jye-sf
approved these changes
Sep 24, 2021
pmdartus
requested changes
Sep 27, 2021
nolanlawson
force-pushed
the
nolan/rollup-plugin-semver
branch
from
bf82b64
to
df685c9
Compare
ekashida
reviewed
Sep 28, 2021
| }, | ||
| "peerDependencies": { | ||
| "rollup": "^1.2.0||^2.0.0" | ||
| "rollup": "^2.29.0" |
There was a problem hiding this comment.
Is v2.29.0 the earliest version of rollup that we can support in the 2.x range?
There was a problem hiding this comment.
Yes, I think so. The meta context was added with this PR which landed in the 2.29.0 release.
pmdartus
approved these changes
Sep 28, 2021
| }, | ||
| "peerDependencies": { | ||
| "rollup": "^1.2.0||^2.0.0" | ||
| "rollup": "^2.29.0" |
There was a problem hiding this comment.
Yes, I think so. The meta context was added with this PR which landed in the 2.29.0 release.
ekashida
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #2505
This PR updates the min semver in the
peerDependenciesRollup version for@lwc/rollup-plugin, and improves the error message if the Rollup version is too old.Does this PR introduce breaking changes?
No, it does not introduce breaking changes.