feat: add flag to render legacy CSS scope tokens #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Sep 25, 2023
| return (this as any)[KEY__LEGACY_SHADOW_TOKEN_PRIVATE]; | ||
| }, | ||
| configurable: true, | ||
| }); |
There was a problem hiding this comment.
This is largely copypasta from shadow-token.ts, but I'm hoping we can just remove it eventually. So creating an abstraction would have just made it harder to remove in the future.
nolanlawson
changed the title
|
/nucleus test |
1 similar comment
|
/nucleus test |
|
/nucleus ignore --reason 'nucleus is having issues, webruntime has brittle snapshot tests' |
jye-sf
reviewed
Sep 25, 2023
jye-sf
approved these changes
Sep 26, 2023
nolanlawson
commented
Sep 26, 2023
packages/@lwc/integration-karma/test/rendering/legacy-scope-tokens/index.spec.js
Show resolved
Hide resolved
nolanlawson
commented
Sep 26, 2023
|
/nucleus ignore --reason 'broken downstreams are gone now' |
nolanlawson
added a commit
that referenced
this pull request
Sep 26, 2023
nolanlawson
added a commit
that referenced
this pull request
Sep 26, 2023
nolanlawson
added a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Adds a runtime flag that, when enabled, renders the legacy CSS attributes/classes in addition to the new ones.
The reason for rendering both is that we still want the SVG static perf optimization, but some folks need the flag enabled to support legacy global stylesheets.
The reason for a runtime flag is because we can't vary the output of the compiler on the flag, so the check must be done entirely at runtime. To accomplish this, we output the compiled template with both tokens, e.g.:
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-14181175