feat: add shortcut for running karma tests #3750
Conversation
There was a problem hiding this comment.
Thanks for the PR, but I'm not really a big fan of this approach. The Jest/Karma tests take up to a minute to run (depending on how fast your machine is), and IME that really slows down velocity during development.
On top of that, if you really want to know whether your commit will pass CI, there are about a dozen different modes it has to run in (see the circleci config), plus the WebDriverIO tests, tests against various browsers, ad-hoc scripts that check for things like license headers... running just Jest/Karma is a false sense of security.
Right now lint-staged does the bare minimum of making sure everything is ESLint formatted and Prettier formatted. I think that's enough for the time being. I've worked on projects where it runs all the unit tests on every commit, and I find that I type -n every time, which nullifies the value of the check.
AllanOricil
force-pushed
the
feat/improve_pre_commit_hook
branch
from
eb309fe
to
0d68c01
Compare
| @@ -20,6 +20,7 @@ | |||
| "test": "jest --config ./scripts/jest/root.config.js", | |||
| "test:debug": "node --inspect node_modules/.bin/jest --config ./scripts/jest/root.config.js --runInBand --watch", | |||
| "test:ci": "yarn test --no-cache --coverage --runInBand", | |||
| "test:karma": "nx test @lwc/integration-karma", | |||
There was a problem hiding this comment.
On its own, this is a good change... it's a nice shorthand, and we were being inconsistent before.
|
most difficult PR of my life 🥹 |
abdulsattar
changed the title
|
Non related. I just want to vent out. I'm really relieved that I started working after the jquery era. Look at this app 😐 |
|
Thank you! ❤️ |
Details
enables developers to run tests from @lwc/integration-karma using
yarn test:karmafrom the root dir.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
N/A