fix: errorCallback was incorrectly invoked in SSR #3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Prior to this PR, the behavior of
errorCallbackin SSR often resembled that in CSR. That behavior is not due to explicit design choices, but rather that the error boundary logic lives in@lwc/engine-coreand doesn't have special conditions for SSR.The decision was made that errors will not be recoverable, they will always bubble up, &
errorCallbackwill never be invoked in the SSR context. The behavior oferrorCallbackand boundaries will remain unchanged for CSR.Does this pull request introduce a breaking change?
Technically yes, but SSR has not been widely adopted yet, so impact is minimal (and positive rather than disruptive).
GUS work item
W-14270071