chore: upgrade jasmine-core and karma-jasmine #3890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ An unexpected error occurred while attempting to start the |
nolanlawson
commented
Dec 6, 2023
| .join('\n'); | ||
| const intro = | ||
| ancestorDirectories.map((tag) => `describe("${tag}", function () {`).join('\n') + | ||
| `\nxit("dummy test", () => { /* empty */ });\n`; |
There was a problem hiding this comment.
I'm not super happy with this, but there's no config option to change Jasmine's default behavior.
nolanlawson
commented
Dec 6, 2023
| }; | ||
|
|
||
| fn(elm); | ||
| }); |
There was a problem hiding this comment.
Apparently this done was firing multiple times in native lifecycle mode. By using a Promise, it only fires the resolve once and Jasmine stops complaining.
nolanlawson
commented
Dec 6, 2023
| } | ||
| }); | ||
| }); | ||
| } |
There was a problem hiding this comment.
This, and the other fixes below, are just fixing empty describes.
ravijayaramappa
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We were previously blocked from upgrading Jasmine because of lack of IE11 support, as well as a breaking change that broke our tests: jasmine/jasmine#1742
The breaking change in Jasmine is basically that Jasmine complains due to the "empty"
describe():Of course we do this a lot.
IE11 is no longer a problem, and we can make some small tweaks to our tests to support the breaking change in Jasmine. This allows us to upgrade.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?