fix(babel-plugin-component): improve error reporting #3912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
If an error is thrown within the Babel plugin itself (e.g. caused by #3910), you get a very unhelpful error because
err.filenameis undefined below, and so it fails when you try topath.basenameit.The resulting error is still not very helpful (and we should address #3910 to resolve that), but this PR makes it so you at least don't get a totally unrelated error message.
I do not believe it's worth adding tests for this, because any error thrown by the plugin is a bug that should be fixed eventually, so any test we write will quickly become stale.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?