fix(template-compiler): exclude comments from static parts when lwc:preserve-comments is disabled
#3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsjtu
commented
Jan 9, 2024
Comment on lines
587
to
592
| if (!(isComment(node) && !this.preserveComments)) { | ||
| // Skip adding part index for comments when preserveComments is disabled. | ||
| // The partId represents the nodes in the DOM tree at runtime, comments will be | ||
| // stripped out when preserveComments is disabled. | ||
| partId++; | ||
| } |
There was a problem hiding this comment.
Exclude comments from the partId count when lwc:preserve-comments is disabled as they will be stripped out at runtime.
ekashida
approved these changes
Jan 9, 2024
packages/@lwc/integration-karma/test/static-content/index.spec.js
Outdated
Show resolved
Hide resolved
packages/@lwc/integration-karma/test/static-content/index.spec.js
Outdated
Show resolved
Hide resolved
packages/@lwc/integration-karma/test/static-content/index.spec.js
Outdated
Show resolved
Hide resolved
packages/@lwc/integration-karma/test/static-content/index.spec.js
Outdated
Show resolved
Hide resolved
packages/@lwc/integration-karma/test/static-content/index.spec.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Eugene Kashida <ekashida@gmail.com>
Co-authored-by: Eugene Kashida <ekashida@gmail.com>
Co-authored-by: Eugene Kashida <ekashida@gmail.com>
Co-authored-by: Eugene Kashida <ekashida@gmail.com>
nolanlawson
approved these changes
Jan 10, 2024
Co-authored-by: Ravi Jayaramappa <ravi.jayaramappa@salesforce.com>
ravijayaramappa
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #3933.
The first commit (de9a127) contains the fix.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
Fixes a bug where comments are being included as part of static parts when
lwc:preserve-commentsis disabled. This causes a mismatch in the partsId between the compiler and runtime.The error that is thrown for this bug will be removed.
GUS work item
W-14786540