chore: improve license header checks @W-14846456 #3951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fail faster than waiting for CI!
In 2022, Salesforce changed from "salesforce.com, inc." to "Salesforce, Inc." https://investor.salesforce.com/press-releases/press-release-details/2022/Salesforce-Changes-Legal-Name-to-Salesforce-Inc/default.aspx
This enables auto-fixes, which is an improvment over the check-license-headers.js script.
wjhsf
commented
Jan 18, 2024
nolanlawson
previously requested changes
Jan 19, 2024
nolanlawson
reviewed
Jan 19, 2024
Headers are enforced for JS/TS files using eslint. Other file types don't need enforcement.
ravijayaramappa
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
In #3949 I changed the headers. That didn't fail until CI, even though it's a trivial check to run locally. So I updated lint-staged to run that check on commit. I also added a new eslint header rule that automatically adds the header, when missing, so that we have to think about it even less!
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-14846456