Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix broken test due to Firefox update #3968

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

nolanlawson
Copy link
Collaborator

Details

Firefox tests are newly failing due to:

Firefox 121.0 (Windows 10) component decorators api non-LightningElement `this` when calling accessor getterSetter setter - external FAILED
	Expected function to throw TypeError with a message matching /(undefined is not an object|Right side of assignment cannot be destructured|vm is undefined|undefined is not a VM|Cannot destructure property '(getHook|setHook)'|Cannot read properties of undefined)/, but it threw TypeError with message 'undefined has no properties'.

This fixes that.

Does this pull request introduce a breaking change?

  • ✅ No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • ✅ No, it does not introduce an observable change.

GUS work item

@nolanlawson nolanlawson requested a review from a team as a code owner February 1, 2024 18:14
@nolanlawson nolanlawson merged commit e0728d0 into master Feb 1, 2024
9 checks passed
@nolanlawson nolanlawson deleted the nolan/fix-firefox-test branch February 1, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants