Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove punctuation from filenames #3994

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Feb 13, 2024

Details

Trying to execute quick bash scripts is made more difficult because of ' in the name of one of the test fixtures. (Which isn't correct, anyway - "its" is the correct form!)

Also renamed some other files with weird punctuation because, well, it's weird.

All filenames now are alphanumeric + -.@_, except this one test component.

Does this pull request introduce a breaking change?

  • ✅ No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • ✅ No, it does not introduce an observable change.

GUS work item

@wjhsf wjhsf requested a review from a team as a code owner February 13, 2024 16:36
Copy link
Member

@ekashida ekashida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@wjhsf wjhsf merged commit 971098d into master Feb 13, 2024
9 checks passed
@wjhsf wjhsf deleted the wjh/no-punctuation-in-filenames branch February 13, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants