Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template-compiler): avoid creating multiple static parts for text containing comments summer24 #4222

Merged
merged 2 commits into from
May 24, 2024

Conversation

jmsjtu
Copy link
Member

@jmsjtu jmsjtu commented May 24, 2024

Details

Backport of #4221

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🔬 Yes, it does include an observable change.

GUS work item

W-15822925

@jmsjtu jmsjtu requested a review from a team as a code owner May 24, 2024 21:24
@jmsjtu jmsjtu merged commit 6ec13cf into summer24 May 24, 2024
9 checks passed
@jmsjtu jmsjtu deleted the jtu/static-content-text-comment-summer24 branch May 24, 2024 22:57
Copy link
Contributor

❌ One or More Pre-release Checks Failed

  • ⚪️ Check PR user has rights to execute the workflow (skipped)
    Skipping PR owner check since PR has already been merged.

  • Check PR is approved
    PR 4222 is approved

  • ⚪️ Check PR is mergeable (skipped)
    PR 4222 has already been merged

  • ⚠️ Check GUS reference is present
    PR does not contain a reference to a GUS work item. You can update it any time by including '@W-XXXXXXX' into the title or body of the PR

  • Check no conflicting Github release
    A Github release already exists with a tag of v6.4.1. Please commit/push a version bump to the jtu/static-content-text-comment-summer24 branch or have Nucleus do it for you by responding with the following comment
    /nucleus bump-version [version]

    To skip this check, run /nucleus release --force

  • Check NPM packages have not been released yet
    Version 6.4.1 of this project has already been published. If you would like to skip NPM publishing, then run /nucleus release --skipNpmRelease.If you want to bump the version in your source branch, run /nucleus bump-version [version]

  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts

  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@jmsjtu jmsjtu mentioned this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants