Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ssr-compiler): harmonize fixture format #4407

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

nolanlawson
Copy link
Collaborator

Details

This does two things:

  1. Ensure that error.txt and expected.html files are always written, even as empty files. This ensures that when you run yarn test on ssr-compiler, it will not unexpectedly create some additional files, e.g. if it expects no error but gets an error. This creates some additional noise on the filesystem, but makes it much easier to test ssr-compiler and engine-server in parallel.
  2. Add an env var, TEST_SSR_COMPILER, that allows for testing the ssr-compiler without having to change the Jest config file.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

@nolanlawson nolanlawson requested a review from a team as a code owner July 25, 2024 18:37
Co-Authored-By: Eugene Kashida ekashida@salesforce.com
Co-Authored-By: Dale Bustad dbustad@salesforce.com
@nolanlawson nolanlawson merged commit d7147ce into master Jul 25, 2024
11 checks passed
@nolanlawson nolanlawson deleted the mob/fix-errors branch July 25, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants